Re: [PATCH 4/4] phy: qcpm-qmp-usb: Add support for QDU1000/QRU1000

[Komal Bajaj]

On 3/11/2024 5:41 PM, Dmitry Baryshkov wrote:
> On Mon, 11 Mar 2024 at 14:05, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:
> > Add QDU1000/QRU1000 specific register layout and table configs.
> >
> > Co-developed-by: Amrit Anand <quic_amrianan@xxxxxxxxxxx>
> > Signed-off-by: Amrit Anand <quic_amrianan@xxxxxxxxxxx>
> > Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> > ---
> >   drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 52 +++++++++++++++++++++++++
> >   1 file changed, 52 insertions(+)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
> > index 5c003988c35d..e067574bea7a 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c
> > @@ -1441,6 +1441,32 @@ static const struct qmp_phy_init_tbl x1e80100_usb3_uniphy_pcs_usb_tbl[] = {
> >          QMP_PHY_INIT_CFG(QPHY_V7_PCS_USB3_RCVR_DTCT_DLY_U3_H, 0x00),
> >   };
> >
> > +
> > +static const struct qmp_phy_init_tbl qdu1000_usb3_uniphy_pcs_tbl[] = {
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_LOCK_DETECT_CONFIG1, 0xc4),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_LOCK_DETECT_CONFIG2, 0x89),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_LOCK_DETECT_CONFIG3, 0x20),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_LOCK_DETECT_CONFIG6, 0x13),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_RCVR_DTCT_DLY_P1U2_L, 0xe7),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_RCVR_DTCT_DLY_P1U2_H, 0x03),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_RX_SIGDET_LVL, 0xaa),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_PCS_TX_RX_CONFIG, 0x0c),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_CDR_RESET_TIME, 0x0a),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_ALIGN_DETECT_CONFIG1, 0x88),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_ALIGN_DETECT_CONFIG2, 0x13),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_EQ_CONFIG1, 0x4b),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_EQ_CONFIG5, 0x10),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_REFGEN_REQ_CONFIG1, 0x21),
> > +};
> > +
> > +static const struct qmp_phy_init_tbl qdu1000_usb3_uniphy_pcs_usb_tbl[] = {
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_USB3_RXEQTRAINING_DFE_TIME_S2, 0x07),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_USB3_LFPS_DET_HIGH_COUNT_VAL, 0xf8),
> > +       QMP_PHY_INIT_CFG(QPHY_V4_PCS_USB3_POWER_STATE_CONFIG1, 0x6f),
> > +};
> > +
> > +
> > +
>
> Please drop extra empty lines.

Sure, will remove the extra lines.

> Also the tables are more or less sorted out. Please move this to a
> correct place.

Will place the tables in sorted order.

> >   struct qmp_usb_offsets {
> >          u16 serdes;
> >          u16 pcs;
> > @@ -1693,6 +1719,29 @@ static const struct qmp_phy_cfg msm8996_usb3phy_cfg = {
> >          .regs                   = qmp_v2_usb3phy_regs_layout,
> >   };
> >
> > +static const struct qmp_phy_cfg qdu1000_usb3_uniphy_cfg = {
> > +       .lanes                  = 1,
> > +
> > +       .offsets                = &qmp_usb_offsets_v5,
> > +
> > +       .serdes_tbl             = sm8150_usb3_uniphy_serdes_tbl,
> > +       .serdes_tbl_num         = ARRAY_SIZE(sm8150_usb3_uniphy_serdes_tbl),
> > +       .tx_tbl                 = sm8350_usb3_uniphy_tx_tbl,
> > +       .tx_tbl_num             = ARRAY_SIZE(sm8350_usb3_uniphy_tx_tbl),
> > +       .rx_tbl                 = sm8350_usb3_uniphy_rx_tbl,
> > +       .rx_tbl_num             = ARRAY_SIZE(sm8350_usb3_uniphy_rx_tbl),
> > +       .pcs_tbl                = qdu1000_usb3_uniphy_pcs_tbl,
> > +       .pcs_tbl_num            = ARRAY_SIZE(qdu1000_usb3_uniphy_pcs_tbl),
> > +       .pcs_usb_tbl            = qdu1000_usb3_uniphy_pcs_usb_tbl,
> > +       .pcs_usb_tbl_num        = ARRAY_SIZE(qdu1000_usb3_uniphy_pcs_usb_tbl),
> > +       .vreg_list              = qmp_phy_vreg_l,
> > +       .num_vregs              = ARRAY_SIZE(qmp_phy_vreg_l),
> > +       .regs                   = qmp_v4_usb3phy_regs_layout,
> > +       .pcs_usb_offset         = 0x1000,
> > +
> > +       .has_pwrdn_delay        = true,
> > +};
> > +
> >   static const struct qmp_phy_cfg sa8775p_usb3_uniphy_cfg = {
> >          .lanes                  = 1,
> >
> > @@ -2620,6 +2669,9 @@ static const struct of_device_id qmp_usb_of_match_table[] = {
> >          }, {
> >                  .compatible = "qcom,sdx65-qmp-usb3-uni-phy",
> >                  .data = &sdx65_usb3_uniphy_cfg,
> > +       }, {
> > +               .compatible = "qcom,qdu1000-qmp-usb3-uni-phy",
> > +               .data = &qdu1000_usb3_uniphy_cfg,
>
> Please keep the table sorted.

Will sort the table.

Thanks
Komal

> >          }, {
> >                  .compatible = "qcom,sdx75-qmp-usb3-uni-phy",
> >                  .data = &sdx75_usb3_uniphy_cfg,
> > --
> > 2.42.0