Re: [PATCH v6 00/13] Add support for NIST P521 to ecdsa

From: Stefan Berger
Date: Tue Mar 19 2024 - 14:56:30 EST




On 3/19/24 14:22, Jarkko Sakkinen wrote:
On Tue Mar 19, 2024 at 12:42 AM EET, Stefan Berger wrote:


On 3/18/24 14:48, Lukas Wunner wrote:
On Tue, Mar 12, 2024 at 02:36:05PM -0400, Stefan Berger wrote:
This series adds support for the NIST P521 curve to the ecdsa module
to enable signature verification with it.

v6 of this series is still

Tested-by: Lukas Wunner <lukas@xxxxxxxxx>

Thanks.

This has been discussed before in LKML but generally tested-by for
series does not have semantical meaning.

Please apply only for patches that were tested.

Ok, I will remove the Tested-by tag.

However, patch 4/13, that only changes a comment, can also be tested in so far as to check whether the code is correct as-is for the tests that 'I' ran and no further modifications are needed for NIST P521. In this case it would mean that a single subtraction of 'n' from res.x seems sufficient and existing code is good as described by the modified comment.


BR, Jarkko