Re: [PATCH] scsi: core: Make scsi_lib KUnit tests modular for real

[Bart Van Assche]

On 3/20/24 01:08, Geert Uytterhoeven wrote:
> On Tue, Mar 19, 2024 at 6:01 PM Bart Van Assche <bvanassche@acmorg> wrote:
> > run SCSI kunit tests is available below. And if there is a desire to run
> > SCSI tests on the target system, how about adding triggers in sysfs for
> > running kunit tests? The (GPL v2) Samsung smartphone kernel supports
> > this but I have not yet checked whether their implementation is
> > appropriate for the upstream kernel.
>
> That would require all tests to be built-in, reducing the amount of memory
> (if any remains at all) available to the real application.

It would be great if it would be possible to convert scsi_lib_test.c
into a kernel module without exporting the functions that are being
tested. Exporting functions from scsi_lib.c only because these are
called from code in scsi_lib_test.c is not desired. More tests may be
added in the future into scsi_lib_test.c. If that would result in
exporting every static scsi_lib.c function that would make the SCSI core
harder to maintain than necessary.

Thanks,

Bart.