Re: [PATCH 3/6] dt-bindings: media: cnm,wave521c: drop resets restriction

From: Rob Herring
Date: Wed Mar 20 2024 - 11:08:45 EST


On Mon, Mar 18, 2024 at 05:42:18PM +0300, Ivan Bornyakov wrote:
> Different designs may have different amount of routed reset signals.
> Drop maxItems restriction, add a small description instead.
>
> Signed-off-by: Ivan Bornyakov <brnkv.i1@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> index 6a11c1d11fb5..2cb4f68d27ac 100644
> --- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> @@ -34,7 +34,8 @@ properties:
> maxItems: 1
>
> resets:
> - maxItems: 1
> + items:
> + - description: Optional reset lines

Your change is a NOP. In fact, the tools will translate an 'items' list
with no constraints back into maxItems/minItems.

So it seems whatever change you think you needed, you did not validate
the change.

Rob