Re: [PATCH v2 1/8] media: qcom: camss: Add CAMSS_8550 enum

[Krzysztof Kozlowski]

On 20/03/2024 15:11, Depeng Shao wrote:
> From: Yongsheng Li <quic_yon@xxxxxxxxxxx>
> 
> Adds a CAMSS SoC identifier for the sm8550.

Why?

> 
> Signed-off-by: Yongsheng Li <quic_yon@xxxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/camss/camss.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index ac15fe23a702..2f63206a8463 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -78,6 +78,7 @@ enum camss_version {
>  	CAMSS_845,
>  	CAMSS_8250,
>  	CAMSS_8280XP,
> +	CAMSS_8550,
>  };

What is the point of this patch alone? What does it change? Why adding
enum? In the next patch, are you going to add one line to some
kerneldoc? Another patch, one function?

Best regards,
Krzysztof