Re: [PATCH v2 4/8] media: qcom: camss: Add new params for csid_device

[Krzysztof Kozlowski]

On 20/03/2024 15:11, Depeng Shao wrote:
> CSID gen3 has a new register block which is named as
> CSID top, it controls the output of CSID, since the
> CSID can connect to SFE or original VFE in CSID gen3.
> The register update is moved to CSID from VFE in CSID
> gen3.
> So, adding top_base and reg_update variables in csid
> device structure for CSID gen3.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/camss/camss-csid.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.h b/drivers/media/platform/qcom/camss/camss-csid.h
> index 4a9e5a2d1f92..ca654b007441 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.h
> +++ b/drivers/media/platform/qcom/camss/camss-csid.h
> @@ -162,7 +162,9 @@ struct csid_device {
>  	struct v4l2_subdev subdev;
>  	struct media_pad pads[MSM_CSID_PADS_NUM];
>  	void __iomem *base;
> +	void __iomem *top_base;
>  	u32 irq;
> +	u32 reg_update;
>  	char irq_name[30];

This is pointless. The are no users of this!

Sorry, don't add random code here or there without concept.

Best regards,
Krzysztof