Re: [PATCH net V1] net: lan743x: Add set RFE read fifo threshold for PCI1x1x chips

From: Simon Horman
Date: Fri Mar 22 2024 - 08:38:45 EST


On Fri, Mar 22, 2024 at 12:16:50PM +0530, Raju Lakkaraju wrote:
> PCI11x1x Rev B0 devices might drop packets when receiving back to back frames
> at 2.5G link speed. Change the B0 Rev device's Receive filtering Engine FIFO
> threshold parameter from its hardware default of 4 to 3 dwords to prevent the
> problem. Rev C0 and later hardware already defaults to 3 dwords.
>
> Fixes: bb4f6bffe33c ("net: lan743x: Add PCI11010 / PCI11414 device IDs")
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@xxxxxxxxxxxxx>
> ---
> Change List:
> ------------
> V0 -> V1:
> - misc_ctl change from int to unsigned int
> - Use FIELD_PREP macro instead of logical shift operator
> - Change 0x3 to macro RFE_RD_FIFO_TH_3_DWORDS

Thanks for the updates,

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>