Re: [PATCH v2 05/14] mm/ksm: use folio in stable_node_dup

[David Hildenbrand]

On 22.03.24 16:57, Matthew Wilcox wrote:
> On Fri, Mar 22, 2024 at 04:36:52PM +0800, alexs@xxxxxxxxxx wrote:
> > -static struct page *stable_node_dup(struct ksm_stable_node **_stable_node_dup,
> > -				    struct ksm_stable_node **_stable_node,
> > -				    struct rb_root *root,
> > -				    bool prune_stale_stable_nodes)
> > +static void *stable_node_dup(struct ksm_stable_node **_stable_node_dup,
> > +			     struct ksm_stable_node **_stable_node,
> > +			     struct rb_root *root,
> > +			     bool prune_stale_stable_nodes)
>
> Do we really have to go through this void * stage?
>
> Also, please stop reindenting the arguments.  I tend to just switch to
> two tabs, but lining them up with the opening bracket leads to extra
> churn.  Either leave them alone for the entire series or switch _once_.

I wish the coding style would at least recommend something -- I know, 
different subsystems/files have their own rules. Nowadays, I prefer 2 
tabs as well.

--
Cheers,

David / dhildenb