Re: [EXTERNAL] [PATCH 2/2] octeontx2-pf: remove unused variables req_hdr and rsp_hdr

From: Dan Carpenter
Date: Mon Mar 25 2024 - 13:06:12 EST


On Mon, Mar 25, 2024 at 12:44:44PM +0000, Subbaraya Sundeep Bhatta wrote:
> Hi,
>
> >-----Original Message-----
> >From: Su Hui <suhui@xxxxxxxxxxxx>
> >Sent: Monday, March 25, 2024 1:06 PM
> >To: Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Geethasowjanya Akula
> ><gakula@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>;
> >Hariprasad Kelam <hkelam@xxxxxxxxxxx>; davem@xxxxxxxxxxxxx;
> >edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> >nathan@xxxxxxxxxx; ndesaulniers@xxxxxxxxxx; morbo@xxxxxxxxxx;
> >justinstitt@xxxxxxxxxx
> >Cc: Su Hui <suhui@xxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> >kernel@xxxxxxxxxxxxxxx; llvm@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> >Subject: [PATCH 2/2] octeontx2-pf: remove unused variables
> >req_hdr and rsp_hdr
> >
> >Clang static checker(scan-buid):
> >drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:503:2: warning:
> >Value stored to 'rsp_hdr' is never read [deadcode.DeadStores]
> >
> Consider this also as a fix and add Fixes tag. Also please add "net" in subject to
> easily identify whether this patch as net or net-next material.
>

It's not a bug fix so it doesn't need a Fixes tag.

regards,
dan carpenter