Re: [PATCH] staging: axis-fifo: Fix indentation

From: Bagas Sanjaya
Date: Mon Apr 01 2024 - 08:26:42 EST


On Tue, Mar 05, 2024 at 11:14:01PM +0200, me@xxxxxxxxxxxxx wrote:
> From: Uri Arev <me@xxxxxxxxxxxxx>
>
> Warning reported by checkpatch.pl script:
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Uri Arev <me@xxxxxxxxxxxxx>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 727b956aa231..ab758a527261 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -381,8 +381,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> - read_timeout);
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + read_timeout);
>
> if (ret <= 0) {
> if (ret == 0) {
> @@ -522,9 +522,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> */
> mutex_lock(&fifo->write_lock);
> ret = wait_event_interruptible_timeout(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> - >= words_to_write,
> - write_timeout);
> + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> + >= words_to_write,
> + write_timeout);
>
> if (ret <= 0) {
> if (ret == 0) {

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>

--
An old man doll... just what I always wanted! - Clara

Attachment: signature.asc
Description: PGP signature