Re: [PATCH] PCI: apple: Fix dependency on 16kB pages

[Marc Zyngier]

On Mon, 01 Apr 2024 13:23:27 +0100,
"Arnd Bergmann" <arnd@xxxxxxxx> wrote:
> 
> On Mon, Apr 1, 2024, at 14:19, Marc Zyngier wrote:
> > While d3e5bab923d3 consolidated the various definitions for page sizes,
> > it ended up breaking the Apple PCIe driver, which still depends on
> > ARM64_PAGE_SHIFT. Switch over to HAVE_PAGE_SIZE_16KB to make the driver
> > selectable again.
> >
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>
> > Cc: "Krzysztof Wilczyński" <kw@xxxxxxxxx>
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Fixes: d3e5bab923d3 ("arch: simplify architecture specific page size 
> > configuration")
> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> 
> The dependency only exists in the asahi kernel with commit
> db5709e83c11 ("PCI: apple: Add depends on ARM64_PAGE_SHIFT = 14")
> and is not present upstream.

You are absolutely right, and I should have checked where this
dependency was coming from.

Apologies for the noise.

	M.

-- 
Without deviation from the norm, progress is not possible.