Re: [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5

From: Konrad Dybcio
Date: Tue Apr 02 2024 - 10:51:25 EST


On 1.04.2024 5:09 PM, Manivannan Sadhasivam wrote:
> These entries are necessary to scale the interconnect bandwidth while
> operating in Gear 5.
>
> Cc: Amit Pundir <amit.pundir@xxxxxxxxxx>
> Fixes: 03ce80a1bb86 ("scsi: ufs: qcom: Add support for scaling interconnects")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---

Skimming through the code, could ufs_qcom_get_bw_table use a
WARN_ON_ONCE(nullcheck)?

FWIW, this change looks sane (without checking the numbers)

Konrad