Re: [PATCH] tty: Convert from tasklet to BH workqueue

From: Jiri Slaby
Date: Thu Apr 04 2024 - 02:18:37 EST


On 03. 04. 24, 18:15, Allen Pais wrote:
The only generic interface to execute asynchronously in the BH context is
tasklet; however, it's marked deprecated and has some design flaws. To
replace tasklets, BH workqueue support was recently added. A BH workqueue
behaves similarly to regular workqueues except that the queued work items
are executed in the BH context.

This patch converts drivers/tty/* from tasklet to BH workqueue.

Quickly looking into the changes, could you also elaborate why not to convert most (all?) of them to (non-BH) wq? Or threaded IRQs. Much of the code comes from the pre-WQ era.

thanks,
--
js
suse labs