Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

From: Andy Shevchenko
Date: Thu Apr 04 2024 - 05:21:45 EST


On Thu, Apr 4, 2024 at 8:07 AM Jiri Slaby <jirislaby@xxxxxxxxxx> wrote:
> On 04. 04. 24, 0:29, Andy Shevchenko wrote:

> >> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> >> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> >> Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
> >> Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> >> Cc: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxx>
> >> Cc: "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxx>
> >> Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx
> >
> > Second, please move these Cc to be after the '---' line
>
> Sorry, but why?

Really need to create a Q&A entry for this.

This will pollute the commit messages with irrelevant (to some extent)
information. Since we have a lore mail archive there is no need to
have this (the email itself will be sent to the list of people,
otherwise the Cc email headers can be tracked in the mail archive).
Also note, some developers may read git history on the mobile devices,
meaning small screens, this just (as for backtraces) simply blurs the
information with a high potential to lose significant piece(s) of
information). Last, but not least is environmentally friendly approach
(I'm not joking): having it on thousands of computers, scrolling with
longer time, power for compressing - decompressing -- all of this
wastes a lot of energy (maybe kWh:s per such a Cc list).

--
With Best Regards,
Andy Shevchenko