Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

[Andy Shevchenko]

On Thu, Apr 4, 2024 at 2:57 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
> On Thu, 4 Apr 2024, Andy Shevchenko wrote:

..

> > > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > > Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
> > > Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> > > Cc: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxx>
> > > Cc: "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxx>
> > > Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx
> >
> > Second, please move these Cc to be after the '---' line
>
> I thought they were placed above the line for audit (and signing)
> purposes.

I didn't get this, sorry.

> There are thousands of Cc lines in the mainline commit messages
> since v6.8.

Having thousands of mistaken cases does not prove it's a good thing to
follow. I answered Jiri why it's better the way I suggested.

> > > Link: https://github.com/vivier/qemu-m68k/issues/44
> > > Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/
> >
> > Missed Fixes tag?
>
> Would this be ok: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> I have to ask because some reviewers do not like to see a Fixes tag cite
> that commit.

Yes, or you even may dig into the history.git from history group (see
git.kernel.org) for the real first patch that brought it.

> > > Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
> > > ---
> > (here is a good location for Cc:)
>
> Documentation/process/submitting-patches.rst indicats that it should be
> above the "---" separator together with Acked-by etc. Has this convention
> changed recently?

I see, I will prepare a patch to discuss this aspect.

-- 
With Best Regards,
Andy Shevchenko