Re: [PATCH 0/2] drm/lima: two driver cleanups

From: Qiang Yu
Date: Thu Apr 04 2024 - 08:52:07 EST


Serial is Reviewed-by: Qiang Yu <yuq825@xxxxxxxxx>

On Tue, Apr 2, 2024 at 6:43 AM Erico Nunes <nunes.erico@xxxxxxxxx> wrote:
>
> Patch 1 is a fix for a crash which triggers on removing the module on
> kernels with CONFIG_DEBUG_SHIRQ enabled, such as the Fedora kernel.
>
> Patch 2 is a fix to this warning:
> drivers/gpu/drm/lima/lima_drv.c:387:13: error: cast to smaller integer
> type 'enum lima_gpu_id' from 'const void *'
> [-Werror,-Wvoid-pointer-to-enum-cast]
> which we have received as a repeated report from the kernel test bot to
> the lima mailing list.
> The warning only reproduces with recent clang on aarch64, but the patch
> does get rid of it and there seem to be no more warnings for W=1.
>
> Erico Nunes (2):
> drm/lima: fix shared irq handling on driver remove
> drm/lima: fix void pointer to enum lima_gpu_id cast warning
>
> drivers/gpu/drm/lima/lima_drv.c | 21 ++++++++++++++++++---
> drivers/gpu/drm/lima/lima_drv.h | 5 +++++
> drivers/gpu/drm/lima/lima_gp.c | 2 ++
> drivers/gpu/drm/lima/lima_mmu.c | 5 +++++
> drivers/gpu/drm/lima/lima_pp.c | 4 ++++
> 5 files changed, 34 insertions(+), 3 deletions(-)
>
> --
> 2.44.0
>