Re: [PATCH v5.10] block: add check that partition length needs to be aligned with block size

From: Greg KH
Date: Fri Apr 05 2024 - 05:31:58 EST


On Tue, Apr 02, 2024 at 02:19:55PM +0530, Ashwin Dayanand Kamat wrote:
> From: Min Li <min15.li@xxxxxxxxxxx>
>
> [ Upstream commit 6f64f866aa1ae6975c95d805ed51d7e9433a0016]
>
> Before calling add partition or resize partition, there is no check
> on whether the length is aligned with the logical block size.
> If the logical block size of the disk is larger than 512 bytes,
> then the partition size maybe not the multiple of the logical block size,
> and when the last sector is read, bio_truncate() will adjust the bio size,
> resulting in an IO error if the size of the read command is smaller than
> the logical block size.If integrity data is supported, this will also
> result in a null pointer dereference when calling bio_integrity_free.
>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Min Li <min15.li@xxxxxxxxxxx>
> Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Link: https://lore.kernel.org/r/20230629142517.121241-1-min15.li@xxxxxxxxxxx
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> Signed-off-by: Ashwin Dayanand Kamat <ashwin.kamat@xxxxxxxxxxxx>
> ---
> block/ioctl.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)

Now queued up,t hanks.,

greg k-h