Re: [PATCH 1/1] i2c: add HAS_IOPORT dependencies

From: Niklas Schnelle
Date: Fri Apr 05 2024 - 05:32:13 EST


On Fri, 2024-04-05 at 11:09 +0200, Wolfram Sang wrote:
> Hi,
>
> On Thu, Apr 04, 2024 at 04:33:51PM +0200, Niklas Schnelle wrote:
> > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> > compile time. We thus need to add HAS_IOPORT as dependency for those
> > drivers using them.
> >
> > Co-developed-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> > Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
>
> Basically OK, but I am asking this question since last June because I
> couldn't find that information in changelogs:
>
> In RFC v1, you agreed to drop PARPORT [1]. Is there a reason you haven't
> done this so far?

Only reasons seems to be that I'm bad at juggling large patch series.
i2c-partport.c builds fine with HAS_IOPORT=n and I don't see a reason
why it wouldn't work with MMIO based parallel port drivers.

Will send a v2 shortly.

Thanks,
Niklas