Re: [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup failure

From: Lukas Wunner
Date: Sun Apr 07 2024 - 17:28:39 EST


On Sun, Apr 07, 2024 at 02:05:26PM -0700, ppwaskie@xxxxxxxxxx wrote:
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -504,7 +504,7 @@ static int cxl_get_chbs(struct device *dev, struct acpi_device *hb,
>
> rc = acpi_evaluate_integer(hb->handle, METHOD_NAME__UID, NULL, &uid);
> if (rc != AE_OK) {
> - dev_err(dev, "unable to retrieve _UID\n");
> + dev_err(dev, "unable to retrieve _UID. Potentially buggy BIOS\n");
> return -ENOENT;
> }

dev_err(dev, FW_BUG "unable to retrieve _UID\n");
^^^^^^

There's a macro for that.