Re: [PATCH] selftests/timers/posix_timers: reimplement check_timer_distribution()
From: Oleg Nesterov
Date: Mon Apr 08 2024 - 06:28:29 EST
On 04/08, Dmitry Vyukov wrote:
>
> >
> > if (ctd_failed)
> > ksft_test_result_skip("No signal distribution. Assuming old kernel\n");
>
> Shouldn't the test fail here? The goal of a test is to fail when
> things don't work.
I've copied this from the previous patch from Thomas, I am fine
either way.
> I don't see any other ksft_test_result_fail() calls, and it does not
> look that the test will hang on incorrect distribution.
Yes, it should never hang.
Thanks,
Oleg.