Re: [PATCH] [v3] parport: mfc3: avoid empty-body warning

From: Geert Uytterhoeven
Date: Tue Apr 09 2024 - 03:52:25 EST


Hi Arnd,

Thanks for your patch!

On Fri, Apr 5, 2024 at 4:43 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> on m68k builds, the mfc3 driver causes a warning about an empty if() block:
>
> drivers/parport/parport_mfc3.c: In function 'control_pc_to_mfc3':
> drivers/parport/parport_mfc3.c:106:37: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
>
> Remove it in favor of a simpler comment.
>
> Acked-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
> Link: https://lore.kernel.org/lkml/20230727122448.2479942-1-arnd@xxxxxxxxxx/

Why the Link-tag, pointing to v2?

> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

For the actual patch:
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds