On Tue, Apr 09, 2024 at 08:45:04AM +0200, michael.opdenacker@xxxxxxxxxxx wrote:
From: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxx>Hi Michael,
This adds initial support for the Milk-V Duo S board
(https://milkv.io/duo-s), enabling the serial port and
read-only SD card support, allowing to boot Linux to the
command line.
I think your patch losts the board binding and have wrong compatiable.
Also, the SD can have rw support with proper property. See link [1]
(need 'disable-wp').
I suggest you resubmitting this patch after applying clk patchs.
This could reduce some unnecessary change. For now, you can just
use the dts for huashan-pi (with changed memory size).
[1]: https://lore.kernel.org/linux-riscv/IA1PR20MB4953B158F6F575840F3D4267BB7D2@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/