Re: [0/2] powerpc/powernv/vas: Adjustments for two function implementations

From: Julia Lawall
Date: Tue Apr 16 2024 - 08:57:37 EST




On Tue, 16 Apr 2024, Christophe Leroy wrote:

>
>
> Le 16/04/2024 à 14:14, Markus Elfring a écrit :
> >> This is explicit in Kernel documentation:
> >>
> >> /**
> >> * kfree - free previously allocated memory
> >> * @object: pointer returned by kmalloc() or kmem_cache_alloc()
> >> *
> >> * If @object is NULL, no operation is performed.
> >> */
> >>
> >> That's exactly the same behaviour as free() in libc.
> >>
> >> So Coccinelle should be fixed if it reports an error for that.
> >
> > Redundant function calls can occasionally be avoided accordingly,
> > can't they?
>
> Sure they can, but is that worth it here ?

Coccinelle does what the developer of the semantic patch tells it to do.
It doesn't spontaneously report errors for anything.

julia