Re: [patch V2 20/50] posix-timers: Consolidate timer setup

From: Anna-Maria Behnsen
Date: Tue Apr 16 2024 - 12:13:41 EST


Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:

> hrtimer based and CPU timers have their own way to install the new interval
> and to reset overrun and signal handling related data.
>
> Create a helper function and do the same operation for all variants.
>
> This also makes the handling of the interval consistent. It's only stored
> when the timer is actually armed, i.e. timer->it_value != 0. Before that it
> was stored unconditionally for posix CPU timers and conditionally for the
> other posix timers.

Shouldn't we do this similar to the gettime() and set it_interval
unconditionally?

Thanks,

Anna-Maria