Re: [PATCH v2 03/10] KVM: x86/mmu: Extract __kvm_mmu_do_page_fault()

[Isaku Yamahata]

On Tue, Apr 16, 2024 at 02:36:31PM +0000,
"Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx> wrote:

> On Wed, 2024-04-10 at 15:07 -0700, isaku.yamahata@xxxxxxxxx wrote:
> > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
> > 
> > Extract out __kvm_mmu_do_page_fault() from kvm_mmu_do_page_fault().  The
> > inner function is to initialize struct kvm_page_fault and to call the fault
> > handler, and the outer function handles updating stats and converting
> > return code.  KVM_MAP_MEMORY will call the KVM page fault handler.
> > 
> > This patch makes the emulation_type always set irrelevant to the return
>            a comma would help parse this better ^
> > code.
> 
> >   kvm_mmu_page_fault() is the only caller of kvm_mmu_do_page_fault(),
> 
> Not technically correct, there are other callers that pass NULL for
> emulation_type.
> 
> > and references the value only when PF_RET_EMULATE is returned.  Therefore,
> > this adjustment doesn't affect functionality.
> 
> Is there a problem with dropping the argument then?
> 
> > 
> > No functional change intended.
> 
> Can we not use the "intended"? It sounds like hedging for excuses.

Thanks for review.
As Chao pointed out, this patch is unnecessary.  I'll use
kvm_mmu_do_page_fault() directly with updating vcpu->stat.

https://lore.kernel.org/all/20240416234334.GA3039520@xxxxxxxxxxxxxxxxxxxxx/
-- 
Isaku Yamahata <isaku.yamahata@xxxxxxxxx>