Re: [PATCH v2 03/10] KVM: x86/mmu: Extract __kvm_mmu_do_page_fault()

From: Paolo Bonzini
Date: Wed Apr 17 2024 - 11:42:20 EST


On Wed, Apr 17, 2024 at 1:52 AM Isaku Yamahata <isaku.yamahata@xxxxxxxxx> wrote:
> As Chao pointed out, this patch is unnecessary. I'll use
> kvm_mmu_do_page_fault() directly with updating vcpu->stat.

Actually I prefer to have this patch.

pf_* stats do not make sense for pre-population, and updating them
confuses things because pre-population (outside TDX) has the purpose
of avoiding page faults.

Paolo