Re: [PATCH 1/3] dt-bindings: mmc: sdhci-of-dwcmhsc: Add Sophgo SG2042 support

From: Chen Wang
Date: Tue Apr 16 2024 - 20:01:01 EST



On 2024/4/17 0:44, Conor Dooley wrote:
On Tue, Apr 16, 2024 at 05:50:37PM +0800, Chen Wang wrote:
[......]
+ anyOf:
+ - minItems: 1
+ items:
+ - description: core clock
+ - description: bus clock for optional
+ - description: axi clock for rockchip specified
+ - description: block clock for rockchip specified
+ - description: timer clock for rockchip specified
+
+ - minItems: 1
I don't think this minItems is needed, this is for one device which has
all 3, no?
Yes, SG2042 requires all the 3 clocks presented,  I will remove this minItems.
I also think this combination should only be permitted for the sg2042,
since it is not valid for the existing devices.
Yes, I will add condition to allow this combination only for sg2042, thanks.
Cheers,
Conor.

[......]