Re: [PATCH 0/3] arm64: mx93: etherrnet: set TX_CLK in RMII mode

From: Sébastien Szymanski
Date: Mon Apr 22 2024 - 05:50:46 EST


Hello,

On 4/22/24 10:46, Steffen Trumtrar wrote:
This series adds support for setting the TX_CLK direction in the eQOS
ethernet core on the i.MX93 when RMII mode is used.

According to AN14149, when the i.MX93 ethernet controller is used in
RMII mode, the TX_CLK *must* be set to output mode.

Must ? I don't think that is true. Downstream NXP kernel has an option to set TX_CLK as an input:

https://github.com/nxp-imx/linux-imx/blob/lf-6.6.y/Documentation/devicetree/bindings/net/nxp%2Cdwmac-imx.yaml#L69

https://github.com/nxp-imx/linux-imx/commit/fbc17f6f7919d03c275fc48b0400c212475b60ec

Regards,


Add a devicetree property with the register to set this bit and parse it
in the dwmac-imx driver.

Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
---
Steffen Trumtrar (3):
dt-bindings: net: mx93: add enet_clk_sel binding
arm64: dts: imx93: add enet_clk_sel
net: stmicro: imx: set TX_CLK direction in RMII mode

.../devicetree/bindings/net/nxp,dwmac-imx.yaml | 10 ++++++++
arch/arm64/boot/dts/freescale/imx93.dtsi | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 27 ++++++++++++++++++++++
3 files changed, 38 insertions(+)
---
base-commit: 4cece764965020c22cff7665b18a012006359095
change-id: 20240422-v6-9-topic-imx93-eqos-rmii-3a2cb421c81d

Best regards,

--
Sébastien Szymanski, Armadeus Systems
Software engineer