Re: [PATCH v2 0/4] Document ASUS RT-AC3200 and ASUS RT-AC5300 and add device trees

From: Arınç ÜNAL
Date: Tue Apr 23 2024 - 03:04:02 EST


On 23/04/2024 09:24, Rafał Miłecki wrote:
Hi,

On 19.04.2024 09:22, Arınç ÜNAL via B4 Relay wrote:
This patch series documents the compatible strings for ASUS RT-AC3200 and
ASUS RT-AC5300, and adds the device trees for them.

I was on holidays and couldn't reply earlier.

This patchset looks good to me, thanks for your work!

Bot warnings come from .dtsi so they are not directly caused by your changes.

Nitpicking:
Try to put "reg" before "device_type" in future.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst?h=v6.8#n112

I'll address this in v3, thank you.

Arınç