RE: [EXT] Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add documentation

[Vabhav Sharma]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Wednesday, May 1, 2024 3:16 PM
> To: Vabhav Sharma <vabhav.sharma@xxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>; Fabio Estevam
> <festevam@xxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>; Ulf Hansson
> <ulf.hansson@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha
> Hauer <s.hauer@xxxxxxxxxxxxxx>; Iuliana Prodan
> <iuliana.prodan@xxxxxxx>
> Cc: Silvano Di Ninno <silvano.dininno@xxxxxxx>; Varun Sethi
> <V.Sethi@xxxxxxx>; Pankaj Gupta <pankaj.gupta@xxxxxxx>; Peng Fan
> <peng.fan@xxxxxxx>; Aisheng Dong <aisheng.dong@xxxxxxx>; Frank Li
> <frank.li@xxxxxxx>; Daniel Baluta <daniel.baluta@xxxxxxx>; Franck
> Lenormand <franck.lenormand@xxxxxxx>
> Subject: [EXT] Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add
> documentation
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On 01/05/2024 07:32, Vabhav Sharma wrote:
> > This patch adds the documentation for the SECVIO driver.
>
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.b/
> ootlin.com%2Flinux%2Fv5.17.1%2Fsource%2FDocumentation%2Fprocess%2F
> submitting-
> patches.rst%23L95&data=05%7C02%7Cvabhav.sharma%40nxp.com%7C4e698
> f57f2be4e4b419c08dc69c39540%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C638501535958415388%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM
> C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C
> %7C%7C&sdata=7NB%2FbjnqJStL2QBVTwGflgSSViD9n8TL78X85OtQX54%3D&
> reserved=0
>
> Describe hardware, not driver.
Ok
>
>
> >
> > Signed-off-by: Franck LENORMAND <franck.lenormand@xxxxxxx>
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@xxxxxxx>
>
>
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives you
> outdated entries. Therefore please be sure you base your patches on recent
> Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so
> fix your workflow. Tools might also fail if you work on some ancient tree
> (don't, instead use mainline), work on fork of kernel (don't, instead use
> mainline) or you ignore some maintainers (really don't). Just use b4 and
> everything should be fine, although remember about `b4 prep --auto-to-cc` if
> you added new patches to the patchset.
Thank you for feedback and used b4 as recommended
>
> You missed at least devicetree list (maybe more), so this won't be tested by
> automated tooling. Performing review on untested code might be a waste of
> time, thus I will skip this patch entirely till you follow the process allowing the
> patch to be tested.
Added the required list
>
> Please kindly resend and include all necessary To/Cc entries.
Ok, done
>
>
> Best regards,
> Krzysztof