Re: [PATCH 6/8] MIPS: Limit MIPS_MT_SMP support by ISA reversion

From: Maciej W. Rozycki
Date: Tue May 14 2024 - 17:46:16 EST


On Fri, 2 Feb 2024, Jiaxun Yang wrote:

> MIPS MT ASE is only available on ISA between Release 1 and Release 5.

R2+ only actually, as also evident from Kconfig...

> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -2171,7 +2171,8 @@ config CPU_R4K_CACHE_TLB
> config MIPS_MT_SMP
> bool "MIPS MT SMP support (1 TC on each available VPE)"
> default y
> - depends on SYS_SUPPORTS_MULTITHREADING && !CPU_MIPSR6 && !CPU_MICROMIPS
> + depends on TARGET_ISA_REV > 0 && TARGET_ISA_REV < 6
> + depends on SYS_SUPPORTS_MULTITHREADING && !CPU_MICROMIPS
> select CPU_MIPSR2_IRQ_VI
> select CPU_MIPSR2_IRQ_EI
^^^^^^
... here. I wish people looked beyond the line they change, sigh...

Maciej