Re: [PATCH v1] dt-bindings: pwm: describe the cells in #pwm-cells in pwm.yaml

From: Uwe Kleine-König
Date: Sat May 18 2024 - 17:50:18 EST


On Fri, May 17, 2024 at 06:38:46PM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> When commit 89650a1e3b6f ("dt-bindings: pwm: Convert PWM bindings
> to json-schema") converted the pwm provider section of the text binding
> to dt-schema it also updated all references to pwm.txt in pwm provider
> bindings to pwm.yaml.
>
> Most pwm provider bindings had a reference to pwm.txt as it contains a
> description of what the cells in #pwm-cells are, albeit in the consumer
> section of the document. Only information in the provider section of the
> document was moved to the yaml binding, and it contains no information
> about the cell format, making all references to it for the cell format
> unhelpful.
>
> Fixes: 89650a1e3b6f ("dt-bindings: pwm: Convert PWM bindings to json-schema")
> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
>
> I yoinked the wording from pwm.txt. Having "Typically" feels a bit
> clumsy, but a given provider is free to override that order AFAIU.

All drivers that have 3 cells use that order, some drivers use less and
skip different values.

The patch looks fine, thanks. Will apply it after the merge window.

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature