Re: [PATCH 2/2] dt-bindings: riscv: cpus: add ref to interrupt-controller

From: Kanak Shilledar
Date: Mon May 20 2024 - 05:40:16 EST


On Mon, May 20, 2024 at 1:02 AM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
>
>
> On Sun, 19 May 2024 23:29:06 +0530, Kanak Shilledar wrote:
> > removed the redundant properties for interrupt-controller
> > and provide reference to the riscv,cpu-intc.yaml which defines
> > the interrupt-controller. making the properties for riscv
> > interrupt-controller at a central place.
> >
> > Signed-off-by: Kanak Shilledar <kanakshilledar111@xxxxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/riscv/cpus.yaml | 22 +------------------
> > 1 file changed, 1 insertion(+), 21 deletions(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.yaml: properties:interrupt-controller: 'oneOf' conditional failed, one must be fixed:
> Additional properties are not allowed ('$ref' was unexpected)
> 'type' is a required property
> hint: DT nodes ("object" type in schemas) can only use a subset of json-schema keywords
> from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240519175906.138410-3-kanakshilledar111@xxxxxxxxxxxxxx

I have fixed the above warning.

> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.

Can you please clarify this part? Is my base commit ID incorrect?
I am currently using the 6.9.0-rc3 kernel version form
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/ repo.

Thanks and Regards,
Kanak Shilledar