Re: [PATCH 2/2] dt-bindings: riscv: cpus: add ref to interrupt-controller

[Conor Dooley]

On Mon, May 20, 2024 at 03:09:44PM +0530, Kanak Shilledar wrote:
> On Mon, May 20, 2024 at 1:02 AM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
> >
> >
> > On Sun, 19 May 2024 23:29:06 +0530, Kanak Shilledar wrote:
> > > removed the redundant properties for interrupt-controller
> > > and provide reference to the riscv,cpu-intc.yaml which defines
> > > the interrupt-controller. making the properties for riscv
> > > interrupt-controller at a central place.
> > >
> > > Signed-off-by: Kanak Shilledar <kanakshilledar111@xxxxxxxxxxxxxx>
> > > ---
> > >  .../devicetree/bindings/riscv/cpus.yaml       | 22 +------------------
> > >  1 file changed, 1 insertion(+), 21 deletions(-)
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.yaml: properties:interrupt-controller: 'oneOf' conditional failed, one must be fixed:
> >         Additional properties are not allowed ('$ref' was unexpected)
> >         'type' is a required property
> >                 hint: DT nodes ("object" type in schemas) can only use a subset of json-schema keywords
> >         from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml#
> >
> > doc reference errors (make refcheckdocs):
> >
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240519175906.138410-3-kanakshilledar111@xxxxxxxxxxxxxx
> 
> I have fixed the above warning.
> 
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> 
> Can you please clarify this part? Is my base commit ID incorrect?

The bot says this in case the error is caused by it having applied
patches on top of 6.9-rc1, but in this case I doubt there's any impact.
By "this patch" it means that having the information in the cover
doesn't help, but info about missing deps should go under the --- line
etc.

| base-commit: 20cb38a7af88dc40095da7c2c9094da3873fea23
| prerequisite-patch-id: 158157d32a32e765834a0cb4fc6335f9009d9962
| prerequisite-patch-id: 4007c7386e66f93b67a2631dddca08cadcee708b

That said, why do you have two prerequisite patches? This applies on top
of 6.9-rc3 without any issues (other than trailing whitespace warnings).

Also, you forgot the v3 tag on this patchset, which confuses tooling:
	shazam https://lore.kernel.org/linux-riscv/20240519175906.138410-1-kanakshilledar111@xxxxxxxxxxxxxx/T/#t
	Grabbing thread from lore.kernel.org/all/20240519175906.138410-1-kanakshilledar111@xxxxxxxxxxxxxx/t.mbox.gz
	Checking for newer revisions
	Grabbing search results from lore.kernel.org
--->	  Added from v2: 1 patches
	Analyzing 10 messages in the thread
--->	Will use the latest revision: v2
	You can pick other revisions using the -vN flag
	Checking attestation on all messages, may take a moment...
	Retrieving CI status, may take a moment...
	Some CI checks failed, see patchwork for more info:
	  https://patchwork.kernel.org/project/linux-riscv/list/?series=854147
	---
	  ✓ [● PATCH v2] dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema
	    + Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
	  ---
	  ✓ Signed: DKIM/gmail.com
	---
	Total patches: 1
	---
	Applying: dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature