Re: [PATCH 2/2] dt-bindings: riscv: cpus: add ref to interrupt-controller

[Kanak Shilledar]

Hi Conor,

Thanks for the clarification.
On Mon, May 20, 2024 at 10:34 PM Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> On Mon, May 20, 2024 at 03:09:44PM +0530, Kanak Shilledar wrote:
> > On Mon, May 20, 2024 at 1:02 AM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote:
> > >



> By "this patch" it means that having the information in the cover
> doesn't help, but info about missing deps should go under the --- line
> etc.

I am still unable to get this part. I don't see there is any dependency
other than the two patches dependent on each other. In my cover letter
I have mentioned that the two patches are dependent on each other.

> | base-commit: 20cb38a7af88dc40095da7c2c9094da3873fea23
> | prerequisite-patch-id: 158157d32a32e765834a0cb4fc6335f9009d9962
> | prerequisite-patch-id: 4007c7386e66f93b67a2631dddca08cadcee708b
>
> That said, why do you have two prerequisite patches? This applies on top
> of 6.9-rc3 without any issues (other than trailing whitespace warnings).

For generation the patches I am using the command:
`git format-patch -2 -o outgoing/ --cover-letter --base=auto`
It is automatically adding those two preqrequisite-patch-ids
automatically along with the base-commit id.
Is it due to the fact that I am having 2 older patches which I have
rolled out already? Shall I remove those
prerequisite patch id from the coverletter to solve this issue?

> Also, you forgot the v3 tag on this patchset, which confuses tooling:

I will fix it in my next version. I haven't changed anything in the
patch so I will add the v3 tag and send it.

>         shazam https://lore.kernel.org/linux-riscv/20240519175906.138410-1-kanakshilledar111@xxxxxxxxxxxxxx/T/#t
>         Grabbing thread from lore.kernel.org/all/20240519175906.138410-1-kanakshilledar111@xxxxxxxxxxxxxx/t.mbox.gz
>         Checking for newer revisions
>         Grabbing search results from lore.kernel.org
> --->      Added from v2: 1 patches
>         Analyzing 10 messages in the thread
> --->    Will use the latest revision: v2
>         You can pick other revisions using the -vN flag
>         Checking attestation on all messages, may take a moment...
>         Retrieving CI status, may take a moment...
>         Some CI checks failed, see patchwork for more info:
>           https://patchwork.kernel.org/project/linux-riscv/list/?series=854147
>         ---
>           ✓ [● PATCH v2] dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema
>             + Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>           ---
>           ✓ Signed: DKIM/gmail.com
>         ---
>         Total patches: 1
>         ---
>         Applying: dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema
>
> Thanks,
> Conor.

Thanks and Regards,
Kanak Shilledar