Re: [PATCH] bpf: constify member bpf_sysctl_kern::table

[Joel Granados]

On Sat, May 18, 2024 at 04:58:47PM +0200, Thomas Weißschuh wrote:
> The sysctl core is preparing to only expose instances of
> struct ctl_table as "const".
> This will also affect the ctl_table argument of sysctl handlers,
> for which bpf_sysctl_kern::table is also used.
...
> Cc: Joel Granados <j.granados@xxxxxxxxxxx>
> Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> ---
>  include/linux/filter.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/filter.h b/include/linux/filter.h
> index 0f12cf01070e..b02aea291b7e 100644
> --- a/include/linux/filter.h
> +++ b/include/linux/filter.h
> @@ -1406,7 +1406,7 @@ struct bpf_sock_ops_kern {
>  
>  struct bpf_sysctl_kern {
>  	struct ctl_table_header *head;
> -	struct ctl_table *table;
> +	const struct ctl_table *table;
>  	void *cur_val;
>  	size_t cur_len;
>  	void *new_val;
> 
> ---
> base-commit: 4b377b4868ef17b040065bd468668c707d2477a5
> change-id: 20240511-sysctl-const-handler-bpf-bec93a18ac68
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> 

Reviewed-by: Joel Granados <j.granados@xxxxxxxxxxx>

-- 

Joel Granados

Attachment: signature.asc
Description: PGP signature