Re: [RFC PATCH 1/5] vsock/virtio: Extend virtio-vsock spec with an "order" field

From: Alyssa Ross
Date: Thu May 23 2024 - 03:43:53 EST


(CCing virtio-comment, since this proposes adding a field to a struct
that is standardized[1] in the VIRTIO spec, so changes to the Linux
implementation should presumably be coordinated with changes to the
spec.)

[1]: https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-4780004

On Fri, May 17, 2024 at 10:46:03PM +0800, Xuewei Niu wrote:
> The "order" field determines the location of the device in the linked list,
> the device with CID 4, having a smallest order, is in the first place, and
> so forth.
>
> Rules:
>
> * It doesn’t have to be continuous;
> * It cannot exist conflicts;
> * It is optional for the mode of a single device, but is required for the
> mode of multiple devices.
>
> Signed-off-by: Xuewei Niu <niuxuewei.nxw@xxxxxxxxxxxx>
> ---
> include/uapi/linux/virtio_vsock.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h
> index 64738838bee5..b62ec7d2ab1e 100644
> --- a/include/uapi/linux/virtio_vsock.h
> +++ b/include/uapi/linux/virtio_vsock.h
> @@ -43,6 +43,7 @@
>
> struct virtio_vsock_config {
> __le64 guest_cid;
> + __le64 order;
> } __attribute__((packed));
>
> enum virtio_vsock_event_id {
> --
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature