Re: [PATCH v2] clocksource: Add node counter timer driver for MIPS/Loongson64

From: Jiaxun Yang
Date: Mon May 27 2024 - 12:32:52 EST




在2024年5月27日五月 下午4:51,Thomas Gleixner写道:
> Jiaxun!
>
Hi Thomas,
[...]
>
> What's this indirection for? Why dont you update
[...]
>
>> +static struct clocksource nodecnt_clocksource = {
>> + .name = "nodecnt",
>> + .read = nodecnt_clocksource_read,
>
> the read function pointer here and spare the indirection?
Smart! sched_clock takes slightly different function pointer argument type
but as we don't use the argument anyway, it should be safe to relax this
indirection.

Will fix in v3.

Thanks
>
> Thanks
>
> tglx

--
- Jiaxun