Re: [PATCH 3/3] arm64: dts: qcom: sdm450: add Lenovo Smart Tab M10 DTS

From: Bjorn Andersson
Date: Mon May 27 2024 - 12:34:09 EST


On Thu, May 23, 2024 at 09:59:35AM GMT, Neil Armstrong wrote:
> diff --git a/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts b/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts
[..]
> +&rpm_requests {
> + regulators {
> + compatible = "qcom,rpm-pm8953-regulators";
[..]
> + pm8953_l8: l8 {
> + regulator-min-microvolt = <2900000>;
> + regulator-max-microvolt = <2900000>;
> + };
[..]
> + pm8953_l11: l11 {
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + };
[..]
> + };
> +};
> +
> +&sdhc_1 {
> + vmmc-supply = <&pm8953_l8>;

JFYI. Not ensuring that the vmmc-supply is in HPM mode bitten us
multiple times in the past.

Regards,
Bjorn