Re: [PATCH] clk: sifive: Do not register clkdevs for PRCI clocks

[Russell King (Oracle)]

On Mon, May 27, 2024 at 05:14:12PM -0700, Samuel Holland wrote:
> These clkdevs were unnecessary, because systems using this driver always
> look up clocks using the devicetree. And as Russell King points out[1],
> since the provided device name was truncated, lookups via clkdev would
> never match.
> 
> Recently, commit 8d532528ff6a ("clkdev: report over-sized strings when
> creating clkdev entries") caused clkdev registration to fail due to the
> truncation, and this now prevents the driver from probing. Fix the
> driver by removing the clkdev registration.
> 
> Link: https://lore.kernel.org/linux-clk/ZkfYqj+OcAxd9O2t@xxxxxxxxxxxxxxxxxxxxx/ [1]
> Fixes: 30b8e27e3b58 ("clk: sifive: add a driver for the SiFive FU540 PRCI IP block")
> Fixes: 8d532528ff6a ("clkdev: report over-sized strings when creating clkdev entries")

This doesn't really fix this commit, since if someone else is doing the
same thing, then they too may also fail to boot, so I'd suggest that
this Fixes tag is removed.

See https://lore.kernel.org/r/E1sBrzn-00E8GK-Ue@xxxxxxxxxxxxxxxxxxxxxx

for a fix that solves the issue introduced by that commit.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!