Re: [PATCH] clk: sifive: Do not register clkdevs for PRCI clocks
From: Stephen Boyd
Date: Wed May 29 2024 - 16:53:37 EST
Quoting Samuel Holland (2024-05-27 17:14:12)
> These clkdevs were unnecessary, because systems using this driver always
> look up clocks using the devicetree. And as Russell King points out[1],
> since the provided device name was truncated, lookups via clkdev would
> never match.
>
> Recently, commit 8d532528ff6a ("clkdev: report over-sized strings when
> creating clkdev entries") caused clkdev registration to fail due to the
> truncation, and this now prevents the driver from probing. Fix the
> driver by removing the clkdev registration.
>
> Link: https://lore.kernel.org/linux-clk/ZkfYqj+OcAxd9O2t@xxxxxxxxxxxxxxxxxxxxx/ [1]
> Fixes: 30b8e27e3b58 ("clk: sifive: add a driver for the SiFive FU540 PRCI IP block")
> Fixes: 8d532528ff6a ("clkdev: report over-sized strings when creating clkdev entries")
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-clk/7eda7621-0dde-4153-89e4-172e4c095d01@xxxxxxxxxxxx/
> Suggested-by: Russell King <linux@xxxxxxxxxxxxxxx>
> Signed-off-by: Samuel Holland <samuel.holland@xxxxxxxxxx>
> ---
Applied to clk-fixes