Re: [PATCH v4 2/4] RAS/AMD/ATL: Expand helpers for adding and removing base and hole

[Borislav Petkov]

On Mon, May 06, 2024 at 03:46:03PM +0000, John Allen wrote:
> +u64 add_base_and_hole(struct addr_ctx *ctx, u64 addr)
>  {
> -	ctx->ret_addr += get_base_addr(ctx);
> -
> -	if (add_legacy_hole(ctx))
> -		return -EINVAL;
> +	addr += get_base_addr(ctx);
> +	return add_legacy_hole(ctx, addr);

	return add_legacy_hole(ctx, addr + get_base_addr(ctx));

That's still readable. :)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette