Re: [PATCH 5/5] arm64: dts: mediatek: mt8188: Add support for Mali GPU on Panfrost

[Julien Panis]

On 5/28/24 12:36, AngeloGioacchino Del Regno wrote:
> Il 27/05/24 16:53, Julien Panis ha scritto:
> > On 5/27/24 11:39, AngeloGioacchino Del Regno wrote:
> > > Add the necessary OPP table for the GPU and also add a GPU node
> > > to enable support for the Valhall-JM G57 MC3 found on this SoC,
> > > using the Panfrost driver.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > ---
> >
> > [...]
> >
> > > +        gpu: gpu@13000000 {
> > > +            compatible = "mediatek,mt8188-mali", "arm,mali-valhall-jm";
> > > +            reg = <0 0x13000000 0 0x4000>;
> > > +
> > > +            clocks = <&mfgcfg CLK_MFGCFG_BG3D>;
> > > +            interrupts = <GIC_SPI 383 IRQ_TYPE_LEVEL_HIGH 0>,
> > > +                     <GIC_SPI 382 IRQ_TYPE_LEVEL_HIGH 0>,
> > > +                     <GIC_SPI 381 IRQ_TYPE_LEVEL_HIGH 0>;
> > > +            interrupt-names = "job", "mmu", "gpu";
> > > +            operating-points-v2 = <&gpu_opp_table>;
> > > +            power-domains = <&spm MT8188_POWER_DOMAIN_MFG2>,
> > > +                    <&spm MT8188_POWER_DOMAIN_MFG3>,
> > > +                    <&spm MT8188_POWER_DOMAIN_MFG4>;
> > > +            power-domain-names = "core0", "core1", "core2";
> >
> > Hi Angelo,
> >
> > I think you should add something like that here:
> > #cooling-cells = <2>;
> > (the warning is raised when I run 'make dtbs_check')
> >
> > Julien
>
> I can either add it to a v2 of this series, or you can add it in your patch where
> you're actually adding the thermal support.
>
> I have no preferences about who adds it, and I agree that cooling-cells should
> eventually get there, so I'll leave the choice to you :-)
>
> Cheers,
> Angelo

I will add it to my patch.
Julien