Re: device_def_domain_type documentation header does not match implementation

From: Baolu Lu
Date: Thu May 30 2024 - 21:19:26 EST


On 5/30/24 9:57 PM, Diederik de Haas wrote:
While looking into ``drivers/iommu/intel/iommu.c::device_def_domain_type``
function I noticed a discrepancy between the documentation header and the
implementation.

``@startup: true if this is during early boot``
0e31a7266508 ("iommu/vt-d: Remove startup parameter from
device_def_domain_type()")
removed the ``startup`` function parameter

returns ``IOMMU_DOMAIN_DMA: device requires a dynamic mapping domain``
28b41e2c6aeb ("iommu: Move def_domain type check for untrusted device into
core")
moved the possible return of ``IOMMU_DOMAIN_DMA`` to ``drivers/iommu/iommu.c``

But neither updated the documentation header.

Yeah, I think the @startup line should be removed. It is irrelevant.
Others remain good to me.

Best regards,
baolu