Re: [PATCH] list: test: remove unused struct 'klist_test_struct'

[Shuah Khan]

On 5/31/24 12:58, Dr. David Alan Gilbert wrote:
> * Muhammad Usama Anjum (usama.anjum@xxxxxxxxxxxxx) wrote:
> > On 5/31/24 8:18 PM, linux@xxxxxxxxxxx wrote:
> > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > >
> > > 'klist_test_struct' has been unused since the original
> > > commit 57b4f760f94d ("list: test: Test the klist structure").
> > Probably a fixes by tag would be needed here.
>
> I'm generally avoiding fixes tags in this set of changes, since
>    a) They have no behavioural change at all.
>    b) Downstream and stable kernel people use fixes tags to indicate
>       stuff they should pick up if they have the original, and there's
>       no need for them to do that with this cleanup.
>
> Dave

+1 on using careful use of Fixes tag only on real fixes for the
reasons mentioned above.

thanks,
-- Shuah