Re: [PATCH] list: test: remove unused struct 'klist_test_struct'

From: David Gow
Date: Fri May 31 2024 - 22:08:07 EST


On Fri, 31 May 2024 at 23:18, <linux@xxxxxxxxxxx> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> 'klist_test_struct' has been unused since the original
> commit 57b4f760f94d ("list: test: Test the klist structure").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> ---

Nice catch, thanks! That's what I get for copy-patste, I guess! :-)

(I agree that this is better without the Fixes tag, too.)

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David

> lib/list-test.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/lib/list-test.c b/lib/list-test.c
> index 0cc27de9cec8..383ee0ad582e 100644
> --- a/lib/list-test.c
> +++ b/lib/list-test.c
> @@ -1201,12 +1201,6 @@ static struct kunit_suite hlist_test_module = {
> };
>
>
> -struct klist_test_struct {
> - int data;
> - struct klist klist;
> - struct klist_node klist_node;
> -};
> -
> static int node_count;
> static struct klist_node *last_node;
>
> --
> 2.45.1
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature