Re: [PATCH 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml

[Krzysztof Kozlowski]

On 31/05/2024 21:37, Frank Li wrote:
> Convert layerscape fsl-esdhc binding doc from txt to yaml format.
> 
> Addtional change during convert:
> - deprecate "sdhci,wp-inverted", "sdhci,1-bit-only".
> - Add "reg" and "interrupts" property.
> - change example "sdhci@2e000" to "mmc@2e000".
> - compatible string require fsl,<chip>-esdhc followed by fsl,esdhc to match
> most existed dts file.
> 


> -};
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-ls-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-ls-esdhc.yaml
> new file mode 100644
> index 0000000000000..cafc09c4f1234
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/fsl-ls-esdhc.yaml

Filename: fsl,esdhc.yaml

> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2

...

> +  clock-frequency:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: specifies eSDHC base clock frequency.
> +
> +  sdhci,wp-inverted:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    deprecated: true
> +    description:
> +      specifies that eSDHC controller reports
> +      inverted write-protect state; New devices should use the generic
> +      "wp-inverted" property.
> +
> +  sdhci,1-bit-only:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    deprecated: true
> +    description:
> +      specifies that a controller can only handle
> +      1-bit data transfers. New devices should use the generic
> +      "bus-width = <1>" property.
> +
> +  sdhci,auto-cmd12:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      specifies that a controller can only handle auto CMD12.
> +
> +  voltage-ranges:
> +    $ref: /schemas/types.yaml#/definitions/uint32-matrix
> +    items:
> +      items:
> +        - description: specifies minimum slot voltage (mV).
> +        - description: specifies maximum slot voltage (mV).
> +
> +  little-endian:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      If the host controller is little-endian mode, specify
> +      this property. The default endian mode is big-endian.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

clock-frequency was required. Isn't it required now?

> +
> +allOf:
> +  - $ref: sdhci-common.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mmc@2e000 {
> +        compatible = "fsl,mpc8378-esdhc", "fsl,esdhc";
> +        reg = <0x2e000 0x1000>;
> +        interrupts = <42 0x8>;
> +        interrupt-parent = <&ipic>;
> +        /* Filled in by U-Boot */
> +        clock-frequency = <0>;

Please provide complete (final) example.

> +        voltage-ranges = <3300 3300>;
> +    };

Best regards,
Krzysztof