Re: [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping support for SR1.0 devices

From: Diogo Ivo
Date: Mon Jun 03 2024 - 05:56:07 EST


Hi Jacob,

On 5/30/24 7:43 PM, Jacob Keller wrote:


On 5/29/2024 9:05 AM, Diogo Ivo wrote:
+ ret = icss_iep_init(prueth->iep0, NULL, NULL, 0);
+ if (ret) {
+ dev_err_probe(dev, ret, "failed to init iep0\n");
+ goto put_iep;
+ }
+
+ ret = icss_iep_init(prueth->iep1, NULL, NULL, 0);
+ if (ret) {
+ dev_err_probe(dev, ret, "failed to init iep1\n");
+ goto exit_iep0;
+ }
+

Once initialized, the icss_iep driver logic must implement the actual
PTP clock interfaces?

Yes exactly, the IEP driver then implements the PHC operations.

Neat.

Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>

Thank you for the review!

Best regards,
Diogo