Re: [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping support for SR1.0 devices

From: Diogo Ivo
Date: Mon Jun 03 2024 - 06:05:33 EST


Hi Simon,

On 6/1/24 1:03 PM, Simon Horman wrote:
On Wed, May 29, 2024 at 05:05:10PM +0100, Diogo Ivo wrote:
+ prueth->iep0 = icss_iep_get_idx(np, 0);
+ if (IS_ERR(prueth->iep0)) {
+ ret = dev_err_probe(dev, PTR_ERR(prueth->iep0), "iep0 get failed\n");

Hi Diogo,

A minor nit from my side.
No need to address this unless there will be a v2 for some other reason.

Networking still prefers code to be 80 columns wide or less.
It looks like that can be trivially achieved here.

Noted :)

Since I already have to address Sunil's comments on patch 2 I'll change
this one too to comply with the 80 character rule.

Thank you for the review!

Best regards,
Diogo