Re: [PATCH] mm: pass the pfn to set_pageblock_migratetype

[Matthew Wilcox]

On Mon, Jun 03, 2024 at 01:48:50PM +0000, Yajun Deng wrote:
> June 3, 2024 at 9:03 PM, "Matthew Wilcox" <willy@xxxxxxxxxxxxx> wrote:
> > On Mon, Jun 03, 2024 at 08:41:00PM +0800, Yajun Deng wrote:
> > > It is necessary to calculate the pfn in the set_pageblock_migratetype(),
> > >  but most of the callers already have the pfn.
> > 
> > It's not exactly a hard computation though. Have you done any
> > 
> > measurements that show this patch is an improvement?
> 
> No, just view the code. But some callers are in a for loop.

All the more reason to MEASURE.  There is a cost to marshalling
function arguments which must be weighed against the cost of
recalculating the PFN.  Since you haven't done that, NAK.